Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unmount between bfs_mtab_parse() and bfs_fstype() causes wrong results #97

Closed
tavianator opened this issue Dec 8, 2022 · 2 comments
Closed

Unmount between bfs_mtab_parse() and bfs_fstype() causes wrong results #97

tavianator opened this issue Dec 8, 2022 · 2 comments
Labels
bug fixed

Comments

@tavianator
Copy link
Owner

See https://github.com/tavianator/bfs/actions/runs/3643266897/jobs/6151312752

Only seemed to happen on a full distcheck, during the release sub-build.
@tavianator
Copy link
Owner Author

tavianator commented Dec 15, 2022 •
edited
Loading

Happened again: https://github.com/tavianator/bfs/actions/runs/3707744220/jobs/6284523171

tavianator added a commit that referenced this issue Dec 15, 2022
@tavianator
[DNM] ci: Debug tests/gnu/fstype failure (#97)
7e4089a
tavianator added a commit that referenced this issue Dec 15, 2022
@tavianator
[DNM] ci: Debug tests/gnu/fstype failure (#97)
8dc4b6a
tavianator added a commit that referenced this issue Dec 15, 2022
@tavianator
[DNM] ci: Debug tests/gnu/fstype failure (#97)
12d78e1
tavianator added a commit that referenced this issue Dec 16, 2022
@tavianator
[DNM] ci: Debug tests/gnu/fstype failure (#97)
319ee84
tavianator added a commit that referenced this issue Dec 16, 2022
@tavianator
[DNM] ci: Debug tests/gnu/fstype failure (#97)
d37d661
tavianator added a commit that referenced this issue Dec 16, 2022
@tavianator
[DNM] ci: Debug tests/gnu/fstype failure (#97)
d426ea7
@tavianator
Copy link
Owner Author

Found it! It's a race against the gnu/inum_automount test (and probably posix/xdev and common/mount). in tests/gnu/fstype, bfs can read the mount table and see the scratch/automnt entry of type autofs. But by the time it does stat() to figure out the device ID, it might already be unmounted, and therefore see the device ID of the parent. Then bfs thinks the fstype of / is autofs.

Not sure what the best fix is.

@tavianator tavianator changed the title Test gnu/fstype is (was?) flaky on CI unmount between bfs_mtab_parse() and bfs_fstype() causes wrong results Dec 16, 2022
@tavianator tavianator changed the title unmount between bfs_mtab_parse() and bfs_fstype() causes wrong results Unmount between bfs_mtab_parse() and bfs_fstype() causes wrong results Dec 16, 2022
@tavianator tavianator added the bug label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tavianator