Sourcery refactored master branch #1

sourcery-ai · 2023-10-28T01:08:56Z

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

changelogg · 2023-10-28T01:08:58Z

Hey! Changelogs info seems to be missing or might be in incorrect format.
Please use the below template in PR description to ensure Changelogg can detect your changes:
- (tag) changelog_text
or
- tag: changelog_text
OR
You can add tag in PR header or while doing a commit too
(tag) PR header
or
tag: PR header
Valid tags: added / feat, changed, deprecated, fixed / fix, removed, security, build, ci, chore, docs, perf, refactor, revert, style, test
Thanks!
For more info, check out changelogg docs

sourcery-ai · 2023-10-28T01:08:58Z

home_assistant_control/config/__init__.py

-        # Order of precedence: CLI > Environment > Config File > Config JSON > Default
-        value = getattr(self.cli.parse(), key, None) or \
-                self.env.get(key) or \
-                self.file.get(section, key) or \
-                self.config_json.get(key) or \
-                default
-        return value
+        return (
+            getattr(self.cli.parse(), key, None)
+            or self.env.get(key)
+            or self.file.get(section, key)
+            or self.config_json.get(key)
+            or default
+        )


Function ConfigManager.get refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

This removes the following comments ( why? ):

# Order of precedence: CLI > Environment > Config File > Config JSON > Default

'Refactored by Sourcery'

236a4cc

sourcery-ai bot requested a review from tayjaybabee October 28, 2023 01:08

sourcery-ai bot commented Oct 28, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sourcery refactored master branch #1

Sourcery refactored master branch #1

sourcery-ai bot commented Oct 28, 2023

changelogg bot commented Oct 28, 2023

sourcery-ai bot Oct 28, 2023

Sourcery refactored master branch #1

Are you sure you want to change the base?

Sourcery refactored master branch #1

Conversation

sourcery-ai bot commented Oct 28, 2023

changelogg bot commented Oct 28, 2023

sourcery-ai bot Oct 28, 2023

Choose a reason for hiding this comment