fix(ui): unneeded chain call (#1338)

tchiotludo · Apr 4, 2023 · 531d21f · 531d21f
1 parent 779ffaa
commit 531d21f
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 40 deletions.
diff --git a/client/src/containers/Connect/ConnectCreate/ConnectCreate.jsx b/client/src/containers/Connect/ConnectCreate/ConnectCreate.jsx
@@ -7,7 +7,7 @@ import Header from '../../Header/Header';
 import constants from '../../../utils/constants';
 import Select from '../../../components/Form/Select';
 import AceEditor from 'react-ace';
-import chain from 'lodash/chain';
+import filter from 'lodash/filter';
 import 'ace-builds/webpack-resolver';
 import 'ace-builds/src-noconflict/mode-json';
 import 'ace-builds/src-noconflict/theme-merbivore_soft';
@@ -218,23 +218,23 @@ class ConnectCreate extends Root {
     let actualGroup = '';
     let sameGroup = [];
     let allOfIt = [];
-    chain(plugin.definitions)
-      .filter(plugin => plugin.name !== 'name' && plugin.name !== 'connector.class')
-      .value()
-      .forEach(definition => {
-        if (definition.group !== actualGroup) {
-          if (actualGroup === '') {
-            actualGroup = definition.group;
-            sameGroup = [definition];
-          } else {
-            allOfIt.push(this.handleGroup(sameGroup));
-            sameGroup = [definition];
-            actualGroup = definition.group;
-          }
+    filter(
+      plugin.definitions,
+      plugin => plugin.name !== 'name' && plugin.name !== 'connector.class'
+    ).forEach(definition => {
+      if (definition.group !== actualGroup) {
+        if (actualGroup === '') {
+          actualGroup = definition.group;
+          sameGroup = [definition];
         } else {
-          sameGroup.push(definition);
+          allOfIt.push(this.handleGroup(sameGroup));
+          sameGroup = [definition];
+          actualGroup = definition.group;
         }
-      });
+      } else {
+        sameGroup.push(definition);
+      }
+    });
     allOfIt.push(this.handleGroup(sameGroup));
     this.setState({ display: allOfIt });
     return allOfIt;
@@ -321,9 +321,10 @@ class ConnectCreate extends Root {
     if (plugin.definitions) {
       this.setState({ plugin }, () => {
         this.handleSchema(
-          chain(plugin.definitions)
-            .filter(plugin => plugin.name !== 'name' && plugin.name !== 'connector.class')
-            .value()
+          filter(
+            plugin.definitions,
+            plugin => plugin.name !== 'name' && plugin.name !== 'connector.class'
+          )
         );
         this.handleData();
       });

diff --git a/client/src/containers/Connect/ConnectDetail/ConnectConfigs/ConnectConfigs.jsx b/client/src/containers/Connect/ConnectDetail/ConnectConfigs/ConnectConfigs.jsx
@@ -9,7 +9,7 @@ import {
 import constants from '../../../../utils/constants';
 import Form from '../../../../components/Form/Form';
 import AceEditor from 'react-ace';
-import chain from 'lodash/chain';
+import filter from 'lodash/filter';
 import 'ace-builds/webpack-resolver';
 import 'ace-builds/src-noconflict/mode-json';
 import 'ace-builds/src-noconflict/theme-merbivore_soft';
@@ -234,23 +234,23 @@ class ConnectConfigs extends Form {
     let actualGroup = '';
     let sameGroup = [];
     let allOfIt = [];
-    chain(plugin.definitions)
-      .filter(plugin => plugin.name !== 'name' && plugin.name !== 'connector.class')
-      .value()
-      .forEach(definition => {
-        if (definition.group !== actualGroup) {
-          if (actualGroup === '') {
-            actualGroup = definition.group;
-            sameGroup = [definition];
-          } else {
-            allOfIt.push(this.handleGroup(sameGroup));
-            sameGroup = [definition];
-            actualGroup = definition.group;
-          }
+    filter(
+      plugin.definitions,
+      plugin => plugin.name !== 'name' && plugin.name !== 'connector.class'
+    ).forEach(definition => {
+      if (definition.group !== actualGroup) {
+        if (actualGroup === '') {
+          actualGroup = definition.group;
+          sameGroup = [definition];
         } else {
-          sameGroup.push(definition);
+          allOfIt.push(this.handleGroup(sameGroup));
+          sameGroup = [definition];
+          actualGroup = definition.group;
         }
-      });
+      } else {
+        sameGroup.push(definition);
+      }
+    });
     allOfIt.push(this.handleGroup(sameGroup));
     this.setState({ display: allOfIt });
   };

diff --git a/client/src/containers/SideBar/Sidebar.jsx b/client/src/containers/SideBar/Sidebar.jsx
@@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
 import { Link, withRouter } from 'react-router-dom';
 import { matchPath } from 'react-router';
 import constants from '../../utils/constants';
-import chain from 'lodash/chain';
+import sortBy from 'lodash/sortBy';
 import './styles.scss';
 import SideNav, { NavIcon, NavItem, NavText } from '@trendmicro/react-sidenav';
 import '@trendmicro/react-sidenav/dist/react-sidenav.css';
@@ -58,10 +58,7 @@ class Sidebar extends Component {
     });
 
     const clusterId = match ? match.params.clusterId || '' : '';
-    let allClusters =
-      chain(clusters)
-        .sortBy(cluster => cluster.id)
-        .value() || [];
+    const allClusters = sortBy(clusters || [], cluster => cluster.id);
     const cluster = allClusters.find(cluster => cluster.id === clusterId);
     this.setState(
       {