Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OIDC] Support for the "Groups field or username field which be inside other fields" case #1320

Merged
merged 4 commits into from
Jan 3, 2023
Merged

[OIDC] Support for the "Groups field or username field which be inside other fields" case #1320

merged 4 commits into from
Jan 3, 2023

Conversation

dongockien92
Copy link
Contributor

In some cases, the groups-field or username-field can be inside other fields.

Ex: The "Token Claim Name" setting on Keycloak 20 has default value is "realm_access.roles"
image

The roles property will be inside the realm_access property
image

@tchiotludo
Copy link
Owner

Hey !!

  • Can you update since there is a conflict?
  • Can you add a relevant unit test please? I'm not sure to understand perfectly!

@tchiotludo
Copy link
Owner

perfect for the rebase, just missing a unit test and it's ok for me!

@dongockien92
Copy link
Contributor Author

Hi @tchiotludo, I'm creating UT, I'll inform you when I completed it.

@dongockien92
Copy link
Contributor Author

@tchiotludo I pushed UT, please help to take a look.

@tchiotludo tchiotludo merged commit a378c62 into tchiotludo:dev Jan 3, 2023
tchiotludo pushed a commit that referenced this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants