KsqlDB support #1324
KsqlDB support #1324
Conversation
|
@dweber019 amazing works !!! 👏 👏 👏 |
|
No worries take your time. |
dweber019
force-pushed
the
dev
branch
5 times, most recently
from
697d263
to
f5f140e
Compare
There was a problem hiding this comment.
Really amazing work 👏
I would address the package lock comment before merging (not my call of course).
One small thing: I had to run prettier manually on most files (the build should fail now since eslint should consider those errors). There's a task npm run prettier:fix for that.
In general, it's probably easier to integrate prettier in the editor you're using (so you don't run into this).
I did some minimal testing (I'm also not a ksqlDB user so hard for me to do extensive tests) and everything I tried works great!
| const { clusterId, ksqlDBId, selectedTab } = this.state; | ||
| const { history, match, location } = this.props; | ||
|
|
||
| switch (selectedTab) { |
There was a problem hiding this comment.
If you introduce a little mapping like:
const tabs = {
info: KsqlDBInfo,
streams: KsqlDBStreams,
tables: KsqlDBTables,
queries: KsqlDBQueries
};Then you can get rid of the switch all together like this:
const SelectedTab = tabs[selectedTab] || KsqlDBStreams;
return (
<SelectedTab
clusterId={clusterId}
ksqlDBId={ksqlDBId}
history={history}
match={match}
location={location}
/>
);Probably a bit of a personal preference but I think the version with the map leads to a little more maintainable code (and it's a little shorter too)
There was a problem hiding this comment.
I tried to keep the code style the same as in the Kafka Connect implementation but your suggestion is much nicer!
Thx
There was a problem hiding this comment.
I would have done the same! I'll go over the kafka connect code soon-ish and see what I can do
| roles: JSON.parse(sessionStorage.getItem('roles')), | ||
| }; | ||
|
|
||
| tabs = ['streams', 'tables', 'queries', 'info']; |
There was a problem hiding this comment.
this could be derived from the keys of the tab mapping I'm suggesting in the next comment
There was a problem hiding this comment.
Used Object.keys(...) for it.
| @@ -0,0 +1,83 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Not sure how to comment on the package lock file line... (sorry)
In the current dev branch we added a nmvrc so you can use nvm to select the "right" node/npm version.
This should get rid of the file change all together (or lead to a much smaller change)
There was a problem hiding this comment.
should be the same as I haven't changed anything. I updated my dev branch.
There was a problem hiding this comment.
maybe something in the way we run the app in dev? I'll investigate.
|
Updated PR. |
|
@dweber019: have you still some things to do on this one? or review is required ? |
|
On my side it good to merge. |
|
@dweber019 not my call (I'm just contributing little things here and there) but if it were up to me I'd revert back the change to the package lock (as I understand it, there's no need for any changes to the file anyway) before merging. As for the rest, it looks good to me (but I'd take it with a grain of salt since I could only do some trivial testing) |
|
Reverted the package lock. |
|
amazing work @dweber019 !! Really appreciate, let people try and send feedback 👍 |
As stated in #115 it would be nice to have a KsqlDB integration.
If have a first contribution working. I think it should be extended in the future as there are more awesome feature to implement but for now the following features are implemented:
Here some impressions, starting with the lists
The server info
The DDL execution window activated with the button "Execute statement"
And the DML window activated with the button "Execute query"
Looking forward to hear your feedback.