Include worker override properties in Connect Configs tab #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchiotludo
pushed a commit
that referenced
this pull request
Apr 4, 2023
…tab (#1344) close #1336 Co-authored-by: alozano3 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue #1336
I've made a few changes. Instead of calling the Connect /validate endpoint with dummy values to retrieve the plugin configs, I send the request with all the configs that the connector has. That way, it returns the specification of all the required definitions and also the ones of the worker overridden properties(producer.override.* and consumer.override.*). Also the type of the values required for validation.
I also changed the transforms properties to follow the same behavior. Instead of having a raw json, there will be a row for each key/value, and now the validations returned from the connect will be applied to the values.
