Replace window pathname by component to fix context-path issues on frontend #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… related issues on frontend
Closed
|
are you sure this syntax |
|
Yep. Indeed, it's "standard" JavaScript https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining |
|
Don't know it was a standard one, thanks for the information and thanks for the pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Micronaut context-path, the React router will use this context-path as base path for the frontend.
This leads to issues especially with login (see #907) because, for context-path = /linked, the returnTo will be set to /linked/ui/login/ (the if test doesn't work because of this basename) and will try to redirect the user to /linked/linked/ui/login. Because this path is unknown, user will view the login page twice.
Using the component pathname fixes the issue because we won't take the basename into account to set returnTo and let the React router add it