Remove basePath on next page URI to prevent no data available error #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tchiotludo ! Will you have time to check this other PR please ? |
|
prefect thanks 🚀 |
tchiotludo
pushed a commit
that referenced
this pull request
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GET /topic/{topicName}/data returns in the after variable the URI to call to get the next page of data. When using context-path in Micronaut, the context-path is added in the URI.
The problem is that we add it another time in the uriTopicData endpoint.
This leads to a /linked/linked/api/... call which fails and show the issue mentionned in #1298.
If we keep only the after URI as it is and don't add the basePath, pagination works well with context-path