Fix newest sort slowness and wrong record number #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AlexisSouquiere
commented
Feb 8, 2023
AlexisSouquiere
commented
- Added a check to stop polling the topic when we are the end offset. It prevents user from experiencing a latency = akhq.topic-data.poll-timeout parameter the first time you try to see the topic content with NEWEST sort
- Fixed the first offset of the search that was causing inconsistency between akhq.topic-data.size and the number of records displayed (returning one more record by partition than expected) when using pagination (no issues on the first page but starting at page 2 we were receiving one more record by partition)
- Fixing wrong number of records with pagination
|
thanks a lot 🚀 |
|
Hello @tchiotludo, could you please tell, approximately, when is the next release? |
|
I've this issue that is blocking the release for now: #1381 |
|
Hi, |
tchiotludo
pushed a commit
that referenced
this pull request
Apr 4, 2023
- Adding stop condition in newest sort to prevent extra polling - Fixing wrong number of records with pagination close #192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.