Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing data download inconsistencies on JSON and CSV format #1442

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Fixing data download inconsistencies on JSON and CSV format #1442

merged 1 commit into from
Mar 30, 2023

Conversation

AlexisSouquiere
Copy link
Collaborator

Linked to #1384

  • JSON: export data in JSON array and handle non-JSON data errors
  • CSV: Fix extra commas to export a CSV-compliant file

@AlexisSouquiere AlexisSouquiere mentioned this pull request Mar 30, 2023
Merged
@tchiotludo tchiotludo merged commit 597aa4e into tchiotludo:dev Mar 30, 2023
@jheinitz
Copy link
Contributor

Hello @AlexisSouquiere !
I just downloaded the latest docker image and tried to download some topic data as JSON, but I get a message with a yellow//orange background saying "Unable to export data in JSON. Please use CSV instead". The docker container does not throw an error. Is there a package missing in the docker image to allow export as JSON?

Image Id used:

[root@kafkacc1test akhq]# docker image ls tchiotludo/akhq:dev
REPOSITORY        TAG       IMAGE ID       CREATED          SIZE
tchiotludo/akhq   dev       6d12631e1c10   27 minutes ago   609MB
[root@kafkacc1test akhq]#

Thanks and regards
Jens

@jheinitz
Copy link
Contributor

Sorry, my fault. I tried to export simple strings published using kafka-console-producer. When I have JSON data in my topic, the export works as expected. Thanks for implementing this.

Best regards
Jens

tchiotludo pushed a commit that referenced this pull request Apr 4, 2023
@AlexisSouquiere @tchiotludo
fix(ui): fixing data download inconsistencies on JSON and CSV format (#…
5c85db9 
…1442)

relate to #1384
markush81 added a commit to markush81/akhq that referenced this pull request Apr 7, 2023
@markush81
Merge branch 'dev' into intellij-avro-generation
5f52a80 
* dev: (56 commits)
  chore(version): update to 0.24.0
  chore(deps): update java deps
  fix(ui): fixing logo not showing on login form (tchiotludo#1449)
  fix(ui): fixing data download inconsistencies on JSON and CSV format (tchiotludo#1442)
  chore(docs): add GrtGaz as AKHQ user (tchiotludo#1439)
  feat(ui): download all messages in a topic to a csv file (tchiotludo#1384)
  fix(ui): clicking on Empty Topic button display blank screen (tchiotludo#1429)
  chore(landing): add baloise logo (tchiotludo#1427)
  fix(ui): don't disabled empty for compact,delete topic
  chore(deps): update all java deps
  fix(topicdata): Use the partition leader from partition info (tchiotludo#1388)
  fix(ui):  harmonize utc labels (tchiotludo#1403)
  fix(ui): fix produce multi / tombstone not working and forms layout issue (tchiotludo#1396)
  fix(auth): fix regex header string for long strim (tchiotludo#1402)
  fix(webserver): reduce default micronaut log to warn  (tchiotludo#1406)
  chore(webserver): warn if security group is wet without a jwt secret (tchiotludo#1412)
  chore(deps): update micronaut (tchiotludo#1405)
  feat(docs): list of available roles in documentation (tchiotludo#1394)
  chore(deps): update all java deps
  fix(ui): handle sche subject with special chars (tchiotludo#1354)
  ...

# Conflicts:
#	build.gradle
#	gradle.properties
#	helm/akhq/Chart.yaml
#	src/test/java/org/akhq/controllers/KsqlDbControllerTest.java
#	src/test/java/org/akhq/repositories/KsqlDbRepositoryTest.java
markush81 added a commit to markush81/akhq that referenced this pull request Apr 7, 2023
@markush81
Merge branch 'dev' into docker-improvements
269c907 
* dev: (56 commits)
  chore(version): update to 0.24.0
  chore(deps): update java deps
  fix(ui): fixing logo not showing on login form (tchiotludo#1449)
  fix(ui): fixing data download inconsistencies on JSON and CSV format (tchiotludo#1442)
  chore(docs): add GrtGaz as AKHQ user (tchiotludo#1439)
  feat(ui): download all messages in a topic to a csv file (tchiotludo#1384)
  fix(ui): clicking on Empty Topic button display blank screen (tchiotludo#1429)
  chore(landing): add baloise logo (tchiotludo#1427)
  fix(ui): don't disabled empty for compact,delete topic
  chore(deps): update all java deps
  fix(topicdata): Use the partition leader from partition info (tchiotludo#1388)
  fix(ui):  harmonize utc labels (tchiotludo#1403)
  fix(ui): fix produce multi / tombstone not working and forms layout issue (tchiotludo#1396)
  fix(auth): fix regex header string for long strim (tchiotludo#1402)
  fix(webserver): reduce default micronaut log to warn  (tchiotludo#1406)
  chore(webserver): warn if security group is wet without a jwt secret (tchiotludo#1412)
  chore(deps): update micronaut (tchiotludo#1405)
  feat(docs): list of available roles in documentation (tchiotludo#1394)
  chore(deps): update all java deps
  fix(ui): handle sche subject with special chars (tchiotludo#1354)
  ...

# Conflicts:
#	build.gradle
#	docker-compose-dev.yml
#	docker-compose.yml
#	gradle.properties
#	helm/akhq/Chart.yaml
#	src/test/java/org/akhq/controllers/KsqlDbControllerTest.java
#	src/test/java/org/akhq/repositories/KsqlDbRepositoryTest.java
markush81 added a commit to markush81/akhq that referenced this pull request Apr 7, 2023
@markush81
Merge branch 'dev' into feature/search-avro-schema-subject
a8a6064 
* dev: (56 commits)
  chore(version): update to 0.24.0
  chore(deps): update java deps
  fix(ui): fixing logo not showing on login form (tchiotludo#1449)
  fix(ui): fixing data download inconsistencies on JSON and CSV format (tchiotludo#1442)
  chore(docs): add GrtGaz as AKHQ user (tchiotludo#1439)
  feat(ui): download all messages in a topic to a csv file (tchiotludo#1384)
  fix(ui): clicking on Empty Topic button display blank screen (tchiotludo#1429)
  chore(landing): add baloise logo (tchiotludo#1427)
  fix(ui): don't disabled empty for compact,delete topic
  chore(deps): update all java deps
  fix(topicdata): Use the partition leader from partition info (tchiotludo#1388)
  fix(ui):  harmonize utc labels (tchiotludo#1403)
  fix(ui): fix produce multi / tombstone not working and forms layout issue (tchiotludo#1396)
  fix(auth): fix regex header string for long strim (tchiotludo#1402)
  fix(webserver): reduce default micronaut log to warn  (tchiotludo#1406)
  chore(webserver): warn if security group is wet without a jwt secret (tchiotludo#1412)
  chore(deps): update micronaut (tchiotludo#1405)
  feat(docs): list of available roles in documentation (tchiotludo#1394)
  chore(deps): update all java deps
  fix(ui): handle sche subject with special chars (tchiotludo#1354)
  ...

# Conflicts:
#	build.gradle
#	client/src/containers/Topic/Topic/Topic.jsx
#	client/src/containers/Topic/Topic/TopicData/TopicData.jsx
#	gradle.properties
#	helm/akhq/Chart.yaml
#	src/test/java/org/akhq/controllers/KsqlDbControllerTest.java
#	src/test/java/org/akhq/repositories/KsqlDbRepositoryTest.java
markush81 added a commit to markush81/akhq that referenced this pull request May 1, 2023
@markush81
Merge branch 'dev' into my-dev
fa0c750 
* dev: (62 commits)
  chore(docker): add unless-stopped (tchiotludo#1445)
  fix(connect): sort throw exception (tchiotludo#1431)
  chore(build): add idea-ext on build.gradle (tchiotludo#1446)
  fix(topicdata): no topic data when 1 record with newest sort  (tchiotludo#1466)
  fix(topicdata): search can failed data pagination with many results (tchiotludo#1468)
  chore(schema): typos
  chore(version): update to 0.24.0
  chore(deps): update java deps
  fix(ui): fixing logo not showing on login form (tchiotludo#1449)
  fix(ui): fixing data download inconsistencies on JSON and CSV format (tchiotludo#1442)
  chore(docs): add GrtGaz as AKHQ user (tchiotludo#1439)
  feat(ui): download all messages in a topic to a csv file (tchiotludo#1384)
  fix(ui): clicking on Empty Topic button display blank screen (tchiotludo#1429)
  chore(landing): add baloise logo (tchiotludo#1427)
  fix(ui): don't disabled empty for compact,delete topic
  chore(deps): update all java deps
  fix(topicdata): Use the partition leader from partition info (tchiotludo#1388)
  fix(ui):  harmonize utc labels (tchiotludo#1403)
  fix(ui): fix produce multi / tombstone not working and forms layout issue (tchiotludo#1396)
  fix(auth): fix regex header string for long strim (tchiotludo#1402)
  ...

# Conflicts:
#	.env
#	build.gradle
#	client/src/containers/Topic/Topic/TopicData/TopicData.jsx
#	gradle.properties
#	helm/akhq/Chart.yaml
#	src/main/java/org/akhq/controllers/SchemaController.java
#	src/test/java/org/akhq/controllers/KsqlDbControllerTest.java
#	src/test/java/org/akhq/repositories/KsqlDbRepositoryTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexisSouquiere @jheinitz @tchiotludo