Add support for GLUE schema registry (only deserialization) #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tchiotludo could you look into this PR please |
|
@arindampatra33 is it possible to add some unit test (mocking something). |
|
@tchiotludo sure will add some test cases , if possible could you tell me where to add ? I mean is there any existing test class where I can add? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My team at booking.com use Glue as the Schema registry and since AKHQ doesn't support Glue, we have a hard time visualising avro/json serialised messages in the AKHQ ui.
This PR adds support for deserializing glue . I have tested with json and avro serialized messages and deserialisation worked fine.
Connection configuration looks like this :
schema-registry: type: "glue" glueSchemaRegistryName: name_of_your_schema_registry awsRegion: aws_region_of_your_schema_registryAuthentication is done using aws default credential provider chain!