Regalloc #16
Merged
Regalloc #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
techie-mike
commented
Mar 5, 2024
techie-mike
commented
- Added liveness analyzer
- Improved linear order
- Fixed GCM
techie-mike
force-pushed
the
regalloc
branch
3 times, most recently
from
0ff7fcf
to
1a3a203
Compare
+ Added liveness analyzer + Improved linear order + Fixed GCM
ober-man
reviewed
Mar 5, 2024
Comment on lines
+48
to
+93
| // OldBegin OldEnd | ||
| // ||-----------|| | ||
| // ||-----------------|| | ||
| // begin end | ||
| // ==============RESULT============== | ||
| // ||---------------------------|| | ||
| // NewBegin NewEnd | ||
| if (begin < begin_ && end < end_) { | ||
| begin_ = begin; | ||
| return; | ||
| } | ||
|
|
||
| // OldBegin OldEnd | ||
| // ||-----------|| | ||
| // ||--------------------------|| | ||
| // begin end | ||
| // ==============RESULT============== | ||
| // ||--------------------------|| | ||
| // NewBegin NewEnd | ||
| if (begin < begin_ && end > end_) { | ||
| begin_ = begin; | ||
| end_ = end; | ||
| return; | ||
| } | ||
|
|
||
| // OldBegin OldEnd | ||
| // ||--------------------------|| | ||
| // ||-----------|| | ||
| // begin end | ||
| // ==============RESULT============== | ||
| // ||--------------------------|| | ||
| // NewBegin NewEnd | ||
| if (begin > begin_ && end < end_) { | ||
| return; | ||
| } | ||
|
|
||
| // OldBegin OldEnd | ||
| // ||---------|| | ||
| // ||-----------|| | ||
| // begin end | ||
| // ==============RESULT============== | ||
| // ||---------------------|| | ||
| // NewBegin NewEnd | ||
| if (begin > begin_ && end > end_) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
OMG man just use std::min, std::max.......
ober-man
reviewed
Mar 5, 2024
| } | ||
| inst->SetLinearNumber(linear_number++); | ||
| if (inst->GetOpcode() != Opcode::Phi) { | ||
| life_number += 2; // +2 reserved for create spill-fill inst. It isn't necessary for Phi inst |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.