Merge pull request #1592 from bombjackit/patch-acquire

_acquire in case of reject return a promise, if this._acquire.promise is used in acquire, in case of reject an exception is raised that is not "captured" by the catch
tediousjs · Jan 16, 2024 · f09c23d · f09c23d
2 parents 1d8a2f4 + 55f5a9f
commit f09c23d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/base/connection-pool.js b/lib/base/connection-pool.js
@@ -363,7 +363,7 @@ class ConnectionPool extends EventEmitter {
    */
 
   acquire (requester, callback) {
-    const acquirePromise = shared.Promise.resolve(this._acquire().promise).catch(err => {
+    const acquirePromise = shared.Promise.resolve(this._acquire()).catch(err => {
       this.emit('error', err)
       throw err
     })
@@ -382,7 +382,7 @@ class ConnectionPool extends EventEmitter {
       return shared.Promise.reject(new ConnectionError('Connection is closing', 'ENOTOPEN'))
     }
 
-    return this.pool.acquire()
+    return this.pool.acquire().promise
   }
 
   /**