-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update C5G7 blueprints from reference #1789
Update C5G7 blueprints from reference #1789
Conversation
Found another change: temperature is specified as 20C. |
@AidanMcDonald Any updates for us? |
@john-science I have been working to get the correct benchmark results and finally succeeded, but the case that replicates the benchmark results is sufficiently different (the benchmark problem blends the fuel and clad together) that I think we shouldn't update the tutorial case to match it. My plan is to have the simpler exact benchmark case live in the openmc plugin and have a separate entry point in the plugin to run this theoretically more accurate case. I will have everything cleaned up and pushed in the coming days. TL;DR: No update yet, but soon. |
I've gone over the reference with a fine-toothed comb and can't find the source of the 90% enrichment number quoted in the comment. I'm now inclined to believe it was just a reasonable assumption like the comment said. I have replaced the old comment with a new one quoting the source of the new number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
Thanks, @AidanMcDonald
Before I go ahead and merge this, one last check: Do you think it's ready for prime time?
Yes. I'm finally done fiddling with this and the homogenized "official" benchmark in the openmc plugin. It's good to go. |
What is the change?
Update a few numbers in C5G7 blueprints to match the reference document.
These specs are from Table 2 on page 6 of the composition/dimensions reference at https://www.oecd-nea.org/upload/docs/application/pdf/2020-01/nsc-doc96-02-rev2.pdf:
Why is the change being made?
I happened to catch a couple minor transcription errors between the C5G7 blueprints in ARMI and the reference while running the C5G7 benchmark problem with the openmc plugin.
Checklist
doc
folder.pyproject.toml
.