Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing deprecation warnings with axial grid method #1809

Merged
merged 6 commits into from
Aug 15, 2024
Merged

Fixing deprecation warnings with axial grid method #1809

merged 6 commits into from
Aug 15, 2024

Conversation

opotowsky
Copy link
Member

@opotowsky opotowsky commented Aug 6, 2024 •
edited
Loading

What is the change?

Updated axialUnitGrid to AxialGrid.fromNCells per the deprecation warning

Why is the change being made?

The unit tests have thousands of warnings and this was some low hanging fruit.

Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@opotowsky opotowsky added cleanup Code/comment cleanup: Low Priority testing Related to tests labels Aug 6, 2024
john-science
john-science approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@john-science john-science left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrielle or John will decide when it is the right time to merge this PR.

@john-science john-science changed the title fix two deprecation warnings with axial grid method Fixing deprecation warnings with axial grid method Aug 6, 2024
@opotowsky opotowsky merged commit 290715b into main Aug 15, 2024
19 checks passed
@opotowsky opotowsky deleted the fix-dep-warning branch August 15, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-science john-science john-science approved these changes

Assignees
No one assigned
Labels
cleanup Code/comment cleanup: Low Priority testing Related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@opotowsky @john-science