-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingesting tabulate as an internal module #1811
Conversation
I think it's fine to pull in 🐫 case throughout and then move code over to armi's tabulate as it makes sense. Should be pretty easy to see where to replace these things. Could also replace things that are 🐍 case with a simple name ( |
Most of that is already included in the docstring for the Lines 1027 to 1043 in cac3324
I considered putting what you linked as a module-level docstring, and reducing this ridiculously long function docstring (>200 lines). I could do that, and find any missing pieces from the docs you linked as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are waiting to merge, but in the meantime: approved! tabulate
is officially pac-manned!
@jakehader I grabbed that README and put it in the module-level docstring in this file. Thanks! |
What is the change?
I removed the
tabulate
dependency, and just ingested the parts of that tool we use toarmi.utils.tabulate
.Why is the change being made?
To close #1749
The problem is that
tabulate
appears to be a nigh abandoned project, and it is keeping us from being able to support modern PIP versions.(Arrielle also points out that we could just replace
tabulate
with something else, likeprettytable
. I am not super convinced my approach here is better than that one. I went this route first because it was easy for me to do, and would be easier to make the update for our downstream repos.)Code Coverage
The code coverage on this file is pretty high:
Checklist
doc
folder.pyproject.toml
.