Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting Python 3.12 #1813

Merged
merged 15 commits into from
Aug 15, 2024
Merged

Supporting Python 3.12 #1813

merged 15 commits into from
Aug 15, 2024

Conversation

john-science
Copy link
Member

@john-science john-science commented Aug 8, 2024

What is the change?

This PR finally brings ARMI up to the Modern age, and supports Python 3.12.

There were two major dependency changes that needed different versions above and below Python 3.11 .

  • ruamel
  • h5py

Also, the unittest library no longer supports the long deprecated self.assertEquals(), just self.assertEqual() in Python 11.

Also, I had to make some rather obscure changes to how we use h5py to get it working in all versions of Python.

Why is the change being made?

It is important that ARMI support as wide a range of versions of Python and Python libraries as possible. This gives our downstream users flexibility to do what they want after they import armi.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the enhancement New feature or request label Aug 8, 2024
@john-science john-science merged commit 9ad6e6c into main Aug 15, 2024
21 checks passed
@john-science john-science deleted the support_python312 branch August 15, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants