fix(2.2.2): 〜つの慣用句に対応 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
「〜つ」に関する慣用句に、「2.2.2 算用数字と漢数字の使い分け」が誤検知してしまうので、回避するよう対応しました。
慣用句：
現実的な範囲でよく使うもののみ対応しています。対応しようとすると他にも「七つの大罪」や「四つ切りサイズ」などもありますが、あまり頻度が高くなさそうですのでこのパッチには含めていません。他にもよくあるものがあれば教えていただけると嬉しいです。
また
ignoreWhenMatched関数の実装も変更していますので、そのあたりも問題ないかや、最適化できそうな実装があれば教えてください。