-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass user to parse and request to render #35
base: master
Are you sure you want to change the base?
Pass user to parse and request to render #35
Conversation
You should then bump your (The request parameter of I didn't do it in this commit as the changes in |
As it seems a lot of extension do not set the parameter when calling Formatter->render(), we fallback to unknown discussion rendering when request is null. We keep logging an error, as this issue should be solved in these extensions. See also <the-turk/flarum-diff#35> for an example of how to fix this issue.
Hmm this is strange. I am sure that it worked, but this does not seem to work anymore. I'm investigating. |
Some extensions like flarum-mentions or club-1-cross-references make use of these additionnal parameters. So we need to pass these to able to render the messages
5b0bb2a
to
e2a1058
Compare
Okay. I just pushed a new commit to pass the correct actor to |
LGTM |
@the-turk Could you please merge? |
You can apply changes in this pr without waiting for @the-turk to merge it and bump a new version on packagist by switching the source of package |
Some extensions like
flarum-mentions
orclub-1-cross-references
make use of these additional parameters. So we need to pass these to able to render the messages.See parse and render signatures from the API docs : https://api.docs.flarum.org/php/v1.6.0/flarum/formatter/formatter
Fixes #34