Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for dimensions and v4 of the api #28

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Aeotrin
Copy link

@Aeotrin Aeotrin commented Oct 29, 2020

This adds support for Dimensions and upgrades the library to use the v4 urls from Canada Post.

@thejacer87
Copy link
Owner

thejacer87 commented Nov 2, 2020

looks like the tests are still failing, can you fix those up before a merge plz

@Aeotrin
Copy link
Author

Aeotrin commented Nov 2, 2020

Sure, ill take a look. Might have been the most recent tracking update change.

@Aeotrin
Copy link
Author

Aeotrin commented Nov 2, 2020

@thejacer87 Did you want me to continue posting patches that match this functionality on the drupal issue: https://www.drupal.org/project/commerce_canadapost/issues/3109833#comment-13887419

Or would you like a new issue made there to match this?
This should also be a major version increment I believe with the constructor definition change.

@thejacer87
Copy link
Owner

@Aeotrin this package was made when i worked at Acro Media. I'm not actively working on anything drupal right now as my full time job isn't with drupal and i dont have the time to work on Drupal otherwise.

we had 1 or 2 clients using this package. the fact that it's not been updated since means im not sure if they still need it (i'm just happy someone can use it)

@krystalcode was my team lead, so he might have more info. but if Acro has no use for the package/module, i dont mind adding you as a maintainer to help your progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants