Use svg icons #162
Merged
Use svg icons #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why mixing 2 libraries? I get it for the GitHub icon (though heh), but the other icons should all come from the same lib IMO. For consistency with the app, it would be nice if it was all from FA5. 🤷♂️ |
|
I wonder, do you find the icons I chose worse than FA's, or it's simply the fact it didn't come from FA? |
|
@astorije I updated the PR, all icons except github are font awesome now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also replaced github icon for the one from https://octicons.github.com/.