Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SVG logos for app stores #166

Merged
merged 1 commit into from
Nov 11, 2018
Merged

Use SVG logos for app stores #166

merged 1 commit into from
Nov 11, 2018

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Nov 8, 2018

No description provided.

@xPaw xPaw requested a review from astorije November 8, 2018 11:28
@xPaw xPaw force-pushed the xpaw/logos branch 2 times, most recently from 73e6319 to b6d9acb Compare November 8, 2018 12:18
@xPaw xPaw changed the title Prefer svg logos Use SVG logos for app stores Nov 8, 2018
@astorije
Copy link
Member

astorije commented Nov 10, 2018

For some reason, the Franz SVG is super pixellated 😕

Master This PR
2018-11-09 22 44 06 2018-11-09 22 44 26

These screenshots were taken on my phone, it seems okay on laptop.

EDIT: I can reproduce on laptop on... hmm Safari only...

@xPaw
Copy link
Member Author

xPaw commented Nov 10, 2018

@astorije I think I fixed it.

@astorije
Copy link
Member

Looks like it. What that the shadow? Is it part of their official logo that we're altering by removing it?

@xPaw
Copy link
Member Author

xPaw commented Nov 10, 2018

I removed the shadow to fix the image overflowing outside the container (in the svg itself), and it doesn't look like it's part of the logo if you look around their site.

It also looks more balanced when displayed next to other logos.

EDIT: For reference, the actual issue with Safari apparently was using width="200%" as it doesn't like percentages.

@astorije
Copy link
Member

it doesn't look like it's part of the logo if you look around their site.

I'm not sure about this: on their website and GitHub repo, their logo (the logo itself, not modified ones such as the square app icon, etc.) always has this ring with shadow.

However, I totally agree with you that it fits better like this on our website. If they are upset about this, they can always come ask us to use another version that doesn't have the bug, and we can remind them to use our official logo on their website ;)

Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@astorije astorije merged commit 8603122 into master Nov 11, 2018
@astorije astorije deleted the xpaw/logos branch November 11, 2018 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants