-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SVG logos for app stores #166
Conversation
73e6319
to
b6d9acb
Compare
@astorije I think I fixed it. |
Looks like it. What that the shadow? Is it part of their official logo that we're altering by removing it? |
I removed the shadow to fix the image overflowing outside the container (in the svg itself), and it doesn't look like it's part of the logo if you look around their site. It also looks more balanced when displayed next to other logos. EDIT: For reference, the actual issue with Safari apparently was using |
I'm not sure about this: on their website and GitHub repo, their logo (the logo itself, not modified ones such as the square app icon, etc.) always has this ring with shadow. However, I totally agree with you that it fits better like this on our website. If they are upset about this, they can always come ask us to use another version that doesn't have the bug, and we can remind them to use our official logo on their website ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
No description provided.