Upgrade jQuery from v2.1.1 to v3.3.1 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlMcKinlay
approved these changes
Oct 22, 2018
|
Is there a reason we aren't using a CDN? |
|
Same reason we're not using them for the main app: privacy, local dev, low-traffic and small website, etc. I'd much rather rely on Netlify's delivery network than a CDN. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #84 to try and keep it in a more reasonable state. First of many.
I know jQuery isn't used much on
masterbut I use it a bit more in #84 and I made sure that it still works there. On the long run we should be able to get rid of jQuery altogether, but for now, keeping it latest.