Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cycle nicks button #1062

Merged
merged 1 commit into from
Apr 26, 2017
Merged

Remove cycle nicks button #1062

merged 1 commit into from
Apr 26, 2017

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Apr 21, 2017

No description provided.

@xPaw
Remove cycle nicks button
999e419 
Reverts #708.
Fixes #869.
Fixes #1023.
@xPaw xPaw added this to the 2.3.0 milestone Apr 21, 2017
@astorije
Copy link
Member

I like that since I took merging the new parser from you, you are passive-aggressively reverting #708 😄

astorije
astorije approved these changes Apr 22, 2017
View reviewed changes
Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but do not merge until #787 makes it into master.

@astorije astorije added Meta: Do Not Merge This PR should not be merged. Type: Feature Tickets that describe a desired feature or PRs that add them to the project. labels Apr 22, 2017
@astorije
Copy link
Member

This effectively "fixes" #1023.

@xPaw xPaw removed the Meta: Do Not Merge This PR should not be merged. label Apr 26, 2017
@xPaw xPaw merged commit dd5e50f into master Apr 26, 2017
@xPaw xPaw deleted the remove-cycle-nicks branch April 26, 2017 08:41
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
@xPaw
Merge pull request thelounge#1062 from thelounge/remove-cycle-nicks
aedb690 
Remove cycle nicks button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astorije astorije astorije approved these changes

Assignees
No one assigned
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xPaw @astorije