Keep track of preview visibility on the server so it persists at page reload #1366
Conversation
astorije
added
the
Type: Feature
src/server.js
Outdated
| @@ -280,6 +280,14 @@ function init(socket, client) { | |||
| client.names(data); | |||
| } | |||
| ); | |||
|
|
|||
| socket.on("msg:preview:toggle", function(data) { | |||
| const chan = client.find(data.target).chan; | |||
There was a problem hiding this comment.
Add undefined checks for all these find
There was a problem hiding this comment.
@xPaw, done, are you okay with how I did that?
|
So doing |
Right, mentioned that in the PR description when I opened it. |
src/server.js
Outdated
|
|
||
| socket.on("msg:preview:toggle", function(data) { | ||
| const networkAndChan = client.find(data.target); | ||
| if (networkAndChan) { |
There was a problem hiding this comment.
You could just return in each if instead of going deeper.
There was a problem hiding this comment.
Done. I honestly prefer the nested version, shorter and makes more sense to me, but whatever.
Adding do not merge label so I remember to squash before merging.
|
Maybe for collapse command we can do an optimization trick where it sends |
|
Agreed we can probably benefit from optimization later, but I won't have the cycles to do that right now. I'll let someone else chime in in a further PR, though I don't believe this will be an issue anyway. |
|
Otherwise, I believe this PR is up for review :) |
astorije
force-pushed
the
astorije/persist-preview-toggle
branch
from
68be238
to
1572892
Compare
…view-toggle Keep track of preview visibility on the server so it persists at page reload
Alright, this will be my last preview-related enhancement for this release.
This is going to be especially useful because of the support for multiple previews per message + the image viewer cycling. Before this PR, collapsing NSFW previews then refreshing then cycling on image previews would display them back, oops!
One issue to keep in mind with this implementation is that running
/collapse//expandwill emit as many times as there are previews to collapse/expand. I don't think this is an issue that is going to have tremendous repercussions performance-wise, so I think any improvements over this can be done in a further PR (help welcome!).