-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HTTP2 #174
Conversation
FYI, Google has deprecated SPDY and will completely drop it this year. I understand this package is not affiliated to Google, but it might be worth looking at consequences a bit more. |
Yeah, but from the look of things, the package isn't going anywhere and supports HTTP2 just fine. |
@xPaw, I'll try to take a look at this over the week-end. |
Seems to be working just fine, 👍 Note: needs to be served over SSL for Chrome to use HTTP/2. Took me a short while before I got it working because of that, so HTTP/1.1 also works just fine still. |
@maxpoulin64 Correct, HTTP2 is TLS only by design (of the protocol). |
FYI, I have been reading this article which covers HTTP/2 with this package, good read if someone wants to know more about it.
Indeed:
I noted the following too, that I could read in different places:
So we're not there yet, but someday we'll be able to simply rely on Express to deal with it on its own, pretty cool!
Not quite, they ended up adding non-HTTPS support to HTTP/2 in the end, to please folks who were against having an HTTPS-only protocol. HTTPS is however the default, and apparently it's a pain to set up non-HTTPS for HTTP/2, and lots of clients would not support it anyway... So in a nutshell, very nice to have The Lounge serving HTTP/2 pages by default when you enable HTTPS! |
http2
module does not work with Express. Closes #173.