Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix textcomplete reference in autocompletion.disable #2023

Merged
merged 1 commit into from
Feb 1, 2018
Merged

Fix textcomplete reference in autocompletion.disable #2023

merged 1 commit into from
Feb 1, 2018

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Jan 31, 2018

Disabling autocompletion and reloading the page triggers it.

@xPaw xPaw added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Jan 31, 2018
@xPaw xPaw added this to the 2.7.1 milestone Jan 31, 2018
astorije
astorije approved these changes Feb 1, 2018
View reviewed changes
Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Not the first time we break this option :/

@astorije astorije merged commit 4f737ce into master Feb 1, 2018
@astorije astorije deleted the xpaw/textcomplete-null branch February 1, 2018 05:31
@astorije astorije changed the title Fix textcomplete reference in autocompletion.disable Fix textcomplete reference in autocompletion.disable Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astorije astorije astorije approved these changes

Assignees
No one assigned
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Milestone
2.7.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xPaw @astorije