Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve monospace formatting in messages #2031

Merged
merged 1 commit into from
Feb 19, 2018
Merged

Conversation

astorije
Copy link
Member

@astorije astorije commented Feb 3, 2018

This effectively styles it just like to code syntax used in the Help window, such as in the list of available commands.

Before After
screen shot 2018-02-03 at 12 49 23 screen shot 2018-02-03 at 12 49 04

This effectively styles it just like to `code` syntax used in the Help window, such as in the list of available commands.
@astorije astorije added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Feb 3, 2018
@astorije astorije modified the milestone: 2.7.1 Feb 3, 2018
Copy link
Member

@AlMcKinlay AlMcKinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@astorije astorije added this to the 3.0.0 milestone Feb 18, 2018
@astorije astorije requested a review from xPaw February 19, 2018 18:02
@xPaw
Copy link
Member

xPaw commented Feb 19, 2018

@astorije as I mentioned on IRC before, this most likely messes up colors when using IRC colors, so that needs figuring out.

@astorije
Copy link
Member Author

Yeah, I'm not sure what we can do about this. I do want to keep the same color as other code though (and grey on grey is not good).
@xPaw, is it that big of a deal? IMO this PR is an improvement already.

@xPaw
Copy link
Member

xPaw commented Feb 19, 2018

@astorije Probably not that big of a deal because this formatter is rather new, and I doubt anyone is going to use it too much with colors.

@xPaw xPaw merged commit 9ecb776 into master Feb 19, 2018
@xPaw xPaw deleted the astorije/irc-monospace branch February 19, 2018 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants