Track channel state to allow removing channels user is not in #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
added
the
Type: Bug
|
Works as expected. When, for some reason, you can't join a channel and you set Lounge to auto join it on connect, you can close the tab without it trying to send a |
xPaw
commented
Feb 14, 2018
| @@ -15,6 +15,11 @@ Chan.Type = { | |||
| SPECIAL: "special", | |||
| }; | |||
|
|
|||
| Chan.State = { | |||
There was a problem hiding this comment.
This can be expanded for queries (#1700) later on to state if user is online or not.
astorije
approved these changes
Feb 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some discussion in #1959.
We recently changed channel part to await server response, but if you were kicked from a channel, PART would never come and the channel would be left dangling.
This tracks channel state (parted or joined) to allow instantly removing channels we're already parted in.
cc @RockyTV for test