Render MOTD with a single message #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
force-pushed
the
xpaw/motd
branch
2 times, most recently
from
c583686
to
e961ddb
Compare
astorije
reviewed
Feb 14, 2018
| @@ -93,8 +93,7 @@ function buildChatMessage(msg) { | |||
| msg.highlight = true; | |||
| } | |||
|
|
|||
| if (constants.actionTypes.indexOf(type) !== -1) { | |||
| msg.template = "actions/" + type; | |||
| if (typeof templates.actions[type] !== "undefined") { | |||
There was a problem hiding this comment.
Very cool. This was long-overdue! 👏
| @@ -19,7 +19,8 @@ const colorRx = /^(\d{1,2})(?:,(\d{1,2}))?/; | |||
| const hexColorRx = /^([0-9a-f]{6})(?:,([0-9a-f]{6}))?/i; | |||
|
|
|||
| // Represents all other control codes that to be ignored/filtered from the text | |||
| const controlCodesRx = /[\u0000-\u001F]/g; | |||
| // This regex allows line feed character | |||
| const controlCodesRx = /[\u0000-\u0009\u000B-\u001F]/g; | |||
There was a problem hiding this comment.
Do you think you could add a test for this regex change? 🙏 🙏
astorije
added
the
Type: Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of splitting it on server and creating
Msgfor every line, just let keep the newlines inparseand let CSS render it correctly.