-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable logging for LDAP users #2098
Conversation
@@ -114,7 +114,7 @@ function ldapAuth(manager, client, user, password, callback) { | |||
// auth plugin API | |||
function callbackWrapper(valid) { | |||
if (valid && !client) { | |||
manager.addUser(user, null); | |||
manager.addUser(user, null, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove || false
here please?
The only place that was not sending it as an argument was this one, so we can have no fallback now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now added this
I suggested that change so obviously I'm 👍 though biased 😅 The rationale behind this is as follows:
It's pretty late but I hope I clarified the intent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you squash your commits into 1? 🙏
In case you don't know how to do this, use git rebase -i HEAD~
, then replace pick
on the second line with f
, save and close, and 🎉, commits are squashed. Then you need to push with git push --force
.
Sorry about that, I have now squashed the commits |
No need to be sorry, it's totally fine and sometimes makes it easier to review new changes after a first review ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keegan FYI, If you want github to link your commits to your account, add email you used in git as a secondary email on github.
No description provided.