Enable logging for LDAP users

[keegan]

No description provided.

[astorije]

Could you remove || false here please?
The only place that was not sending it as an argument was this one, so we can have no fallback now.

[keegan]

I have now added this

[astorije]

I suggested that change so obviously I'm 👍 though biased 😅

The rationale behind this is as follows:

• As opposed to local-auth users which are created from the command line (which prompts yes/no for disk logs), there is no such thing with LDAP, a new user gets created on first login, and is given a default value for logs (currently false, true after this PR)
• Before this PR, there is no way to auto-set to true, all new users have logs disabled. After this PR, it will be the opposite scenario.
• Add sqlite logging and reloading messages #1839 gets merged, it will be possible to disable logs globally with messageStore: none. Without this PR, it will still be impossible to enable logs by default even after Add sqlite logging and reloading messages #1839.
• In Prompt admin for user log at user creation #903, we made the prompt for local-auth default to yes, so this is consistent.

It's pretty late but I hope I clarified the intent.
Once users can edit their settings from the UI, this will be much easier to deal with on a per-user case.

[astorije]

Thanks! Could you squash your commits into 1? 🙏

In case you don't know how to do this, use git rebase -i HEAD~, then replace pick on the second line with f, save and close, and 🎉, commits are squashed. Then you need to push with git push --force.

[keegan]

Sorry about that, I have now squashed the commits

[astorije]

No need to be sorry, it's totally fine and sometimes makes it easier to review new changes after a first review ;)
I approved, hopefully we can get that merged and in a pre-release soon!

[xPaw]

@keegan FYI, If you want github to link your commits to your account, add email you used in git as a secondary email on github.