Update dependency web-push to v3.3.1

[renovate]

This Pull Request updates dependency web-push from v3.3.0 to v3.3.1

Release Notes

v3.3.1

Compare Source

---

---

This PR has been generated by Renovate Bot.

[xPaw]

@rarkins Any idea why github isn't complaining about this PR (and #2460) not being out of date? It's trying to update sinon which was already updated in master. Looks like a failed rebase or something.

[xPaw]

Looks like it finally managed to rebase itself.

[rarkins]

@xPaw unless you have enabled "all PRs must be up-to-date with master" branch protection for a repository, or you have explicitly turned it on with Renovate's rebaseStalePrs set to true, then Renovate assumes that you don't want aggressive rebasing and therefore only does it once a conflict occurs. If you want Renovate to always rebase its PRs when it detects a change to master then you can add the preset :rebaseStalePrs to your extends array in config.

[xPaw]

Cool I will add that to the config.

The reason I pinged you is because this PR initially had 2 package changes (web-push and sinon) which should have been conflicting with master, but for some reason did not.

[rarkins]

In terms of conflicts, that's determined by git/GitHub and Renovate just uses the API to retrieve the value. Rebasing stale is the safest way to update dependencies because then you're sure it's always tested against master every time, but it results in more CI builds so that's why it's not default behaviour.

Sorry I missed the message yesterday, btw. It was a tough day due to versions disappearing from npmjs so I was getting a lot of notifications.

[xPaw]

Yeah I know GitHub does the conflict checking, which is why I found it very odd that it didn't find a conflict here. I primarly wanted to know why renovate-bot included unrelated package update in this PR.

No worries about the delay, thanks for your support!