-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace current red-text highlight with a full background-color highlight #2526
Conversation
Is it actually blocked on that PR? The commit that changes highlights doesn't seem to conflict. You just brought in 2 extra commits that are unrelated. |
41b2ae6
to
118866c
Compare
Yeah I get a few conflicts that I can't be bothered to fix. I'm hoping we can be done with #2315 in a couple days so this one can make it then.
That's because I rebase like an idiot. Fixed. |
118866c
to
d2718ea
Compare
d2718ea
to
d8719c8
Compare
d8719c8
to
608cf93
Compare
608cf93
to
525cc56
Compare
client/css/style.css
Outdated
color: #e74c3c; | ||
} | ||
|
||
#chat .message.highlight { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that I accidentally removed .channel
and therefore this highlights in queries too. I was about to re-add it, then wondered if .highlight
class should be in queries at all. Any insight, @xPaw?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the .channel
.
All query messages are highlights, we don't want to style them.
525cc56
to
0592ec3
Compare
@astorije On mobile view there's padding around highlights. Do we want to remove these (I did that in Solarized). |
0592ec3
to
805b352
Compare
@xPaw, fixed the highlights in queries, and removed the paddings on mobile. Should be good to go. |
client/css/style.css
Outdated
} | ||
|
||
#chat .channel .message.highlight .from::after { | ||
background: transparent; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed. It was a relic from https://github.com/thelounge/thelounge/pull/2270/files#diff-97db1f70168fb5f12457b238ff6052b5L2230, thanks for noticing!
805b352
to
c2ce562
Compare
All good now.
Supersedes #1847 and #1846.
Inspired by @xPaw's approach at #1847 (comment).
I am using colors given by https://color.adobe.com/ to match our main color to match it with our actual "new" blue.
Default theme:
Morning theme: