Do not write /list messages to logs #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
added
the
Type: Bug
AlMcKinlay
approved these changes
Jul 10, 2018
| @@ -46,6 +46,9 @@ class Msg { | |||
| this.type !== Msg.Type.ERROR && | |||
| this.type !== Msg.Type.BANLIST && | |||
| this.type !== Msg.Type.IGNORELIST && | |||
| this.type !== "channel_list" && | |||
There was a problem hiding this comment.
Why are these not in the enum? They probably should be.
There was a problem hiding this comment.
That's what I meant, these types are all gone in Vue which is why I didn't bother adding them to the enum.
There was a problem hiding this comment.
Oh I missed that in your description. Ignore me. Alrighty.
| @@ -46,6 +46,9 @@ class Msg { | |||
| this.type !== Msg.Type.ERROR && | |||
There was a problem hiding this comment.
It would probably be nice to create an array of types that we don't log and switch the code to
return this.TYPES_NOT_TO_LOG.includes(this.type)
Might be nicer overall?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while working on Vue, this is a temporary fix (hence why I'm not adding new types for it) as this isn't a problem in Vue branch (it doesn't use Msg at all).