Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for echo-message and znc.in/self-message caps #270

Merged
merged 2 commits into from
Apr 30, 2016
Merged

Add support for echo-message and znc.in/self-message caps #270

merged 2 commits into from
Apr 30, 2016

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Apr 22, 2016 •
edited
Loading

  • Add support for echo-message and znc.in/self-message caps.
    • znc.in/self-message because latest znc version still does not have echo-message, and people often don't upgrade their ZNC for a long time
  • Moved query/invite highlight logic from the client to the server
    • Fixes self messages received in query windows triggering a highlight

Fixes #269 and #74

@xPaw xPaw added Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. Type: Feature Tickets that describe a desired feature or PRs that add them to the project. labels Apr 22, 2016
@xPaw xPaw changed the title Ircv3/echo message Add support for echo-message and znc.in/self-message caps Apr 22, 2016
@maxpoulin64
Copy link
Member

👍 makes reconnecting to ZNC a lot more cleaner!

@astorije
Copy link
Member

👍

@astorije astorije merged commit 404bf2c into master Apr 30, 2016
@astorije astorije deleted the ircv3/echo-message branch April 30, 2016 23:37
@astorije astorije mentioned this pull request Apr 30, 2016
Closed
@astorije astorije added this to the ★ Next Release milestone May 15, 2016
@astorije astorije mentioned this pull request Feb 1, 2017
Merged
@dgw dgw mentioned this pull request Feb 6, 2017
Closed
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
@astorije
Merge pull request thelounge#270 from thelounge/ircv3/echo-message
fa2e8ab 
Add support for echo-message and znc.in/self-message caps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maxpoulin64 maxpoulin64

Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xPaw @maxpoulin64 @astorije