-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change nicks from links to spans everywhere #428
Conversation
👍 |
This fixes the search after changing from buttons to spans.
@xPaw, I found a bug with the user search not working anymore, fixed in a commit, hope you don't mind! One sad side-effect of going from links to spans is that we lose ability to tab and receive focus. @cptvitamin gave us some pointers to solve this at #338 (comment). @cptvitamin, feel free to jump in if you want to add anything to the discussion here :-) |
@astorije Good fix. I know I didn't set tabindex, is it that desired of a feature to tab index all the nicks in chat window? |
@@ -1,2 +1,2 @@ | |||
<a href="#" class="user {{colorClass from}}" data-name="{{from}}">{{mode}}{{from}}</a> | |||
<span role="button" class="user {{colorClass from}}" data-name="{{from}}">{{mode}}{{from}}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be accessible these will need a tabindex=0
and keyboard event listeners (Space and Enter) to work.
@cptvitamin see my comment above, I'm well aware of tabindex. The question is, do we want to make nicks tabbable in chat? Currently if you're focused in the input you can't tab out, and to tab in the chat window you have to select some text first so that you won't be focused in the input again. |
Follow-up of a discussion on the IRC channel (redacted for simplicity):
@xPaw raised a good point that tabbing the message window has little value. It's actually the opposite, it clouds tabbing across links given in messages. So I agree that making nicks non-tabbable will make for a better experience. Nicks should however be tabbable in the user list. It's the case at the moment, but it's rather broken as you have no visual feedback at all. It works fairly well with VoiceOver though. However, these statements assume that it is possible to leave the input field once it is focused, which is not the case (and even so, it's not easy to access things like the channel list or user list)... So I am 👍 here even though the user list is losing in keyboard-control, but that's only because it's not possible to access that area from the keyboard. @cptvitamin, any suggestions to make the different areas of the app themselves accessible from the keyboard are welcome! |
Change nicks from links to spans everywhere
Fixes #338
This removes the dumb "#" hover link previews.