Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nick changes not being properly reported in the logs #685

Merged
merged 1 commit into from
Oct 15, 2016

Conversation

astorije
Copy link
Member

@astorije astorije commented Oct 10, 2016

Result

When typing /nick astorije2 (or using the nick editor) and tailing the according log file:

Before After
[2016-10-10 15:17:47] * nick [2016-10-10 16:32:47] * astorije nick astorije2

Before:

```
[2016-10-10 15:17:47] *  nick
```

After:

```
[2016-10-10 16:32:47] * astorije nick astorije2
```
@astorije astorije added Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. second review needed labels Oct 10, 2016
@MaxLeiter
Copy link
Member

Works fine for me

@xPaw xPaw added this to the 2.1.0 milestone Oct 15, 2016
@xPaw xPaw merged commit a58b783 into master Oct 15, 2016
@xPaw xPaw deleted the astorije/fix-nick-in-logs branch October 15, 2016 11:00
@xPaw xPaw self-assigned this Oct 15, 2016
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
…logs

Fix nick changes not being properly reported in the logs
@xPaw xPaw removed their assignment Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants