-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context menus #9
Conversation
OS: Fedora 23 The context menu opens fine but the buttons have no action and the menu closes as soon as I try clicking an option. Investigating now. |
@MaxLeiter Try setting higher |
No effect @xPaw, tried multiple different values (including the maximum for |
Worked great with the fix, 👍 |
(Can be rebased off |
Righty, so I'm really liking this. However, just a little thing, we probably shouldn't have a settings option on the context menu if we haven't implemented channel specific settings. Finally, it would be good if the context menu for users had a "mention" option. If the first happens, I'll give me +1. If the second happens as well, you get bonus points. |
@YaManicKill is it fine by you if I just comment it out? We will need it eventually. |
I'm never a massive fan of adding commented out code, tbh. I'd prefer it if we just removed it entirely until we use it. Feel free to stick it up on a branch so the code doesn't get lost. |
@YaManicKill Removed. |
Awesome. 👍 from me. |
Great job @xPaw :-) A few comments:
|
Have fun clicking a small arrow on a mobile device, holding down on a channel name is much more intuitive and doesn't require tapping into pixels perfectly.
I don't see why not.
Displaying a "heading" with channel/user name in context menu is helpful to see on which entry you clicked on. And making it clickable to bring it into focus is just a bonus. (e.g. username opens a query, and server brings it into focus). Plus, if we ever add context menus to channel names in parsed messages, we can add
Will take a look. EDIT: |
I've rebased the PR and fixed a bug where menu could go off screen due to incorrect position calculation. |
Yeah, I agree with @xPaw on this one.
Yeah, I think this is reasonably self-explanitory what would happen. If you are in the room, take you to the room. If you aren't in the room (when we can click on room names in chat) then join the room and take you there. Makes sense to me. |
👍 I like it and am looking forward to a bunch of the actions that could be added to it, especially on mobile. It will just need to be rebased for #94's new templates (and maybe #91?) I also agree with @xPaw and @YaManicKill, especially on mobile. I hate having to aim for a small menu when I can just right click anywhere, and tapping small things is a nightmare especially when you want to do it quickly. Maybe when there's more options in the menu we could replace the [x] by the icon as @astorije suggested but keep the right click? We could also replace the [Leave][Close] button in channel windows by a [Menu] that opens the dropdown as well, so the menu is easy to spot. |
Re: that hard to click on menu icon, I agree with you. On mobile, it's impractical. I am ready to bend to the general will here (as long as context menu actions are available somewhere else!!) but I am still thrown off a lot by the right click menu (and context menu in general, but that's different). Modern mobile UX simply do not rely on right click (well, long click) menus as they are hidden (i.e. not intuitive at all) and hard to reach (have to wait 1 second or so every time, have to make sure you click on the right item, ...). I'm OK going for this as is at the moment, but still feel like here right click menu is a cheap solution to a real UX concern. I do believe we should be more considerate of global UX rather than throwing everything we don't know where to put in the context menu. But by adding my requirement of never having something that is not available somewhere else (which is very common when you think about it), I guess this is addressed. So here you are, I believe I have shared all my UX concerns and conditions :-) |
@astorije: Yeah, I would definitely keep those options available elsewhere as well. This is why I proposed to duplicate them with the [Leave] button in a channel and so on. So it's really just another way or a shortcut to do actions from the sidebar. As for the menus on user names, I guess we could open the menu on click. This is where I assume we will add the most options in the future (such as op, voice, kick, ban, kickban, mention, query, whois). I will be really happy when I will be able to make a PR to add a menu item to have the selected nick added to the input field! Right now highlighting someone whose name is not trivial is horrible. |
I liked the idea of opening menu when clicking on names, but I'm sure when I suggested that a while ago, someone didn't like it. Was it @astorije ? Other than that, I'm totally 👍 on this as it is just now, and we can improve it over time. It's a reasonably big change and it's a great feature that we don't want to wait too long to get it in. |
This PR already has multiple 👍, merging. Lets just keep in mind to keep the buttons as well for touch-friendliness. |
Wooo. Can we remove the hover close button now? 😛 |
@YaManicKill No, not yet. @astorije still has some accessibility concerns about this one and it was merged semi-accidentally. Plus the close button is kinda useful when I do channel cleanup and close a bunch at once. So far there is no reason to replace it so I think it should stay there for now. We should agree on accessibility concerns before putting things only available through context menus. We'll remove/replace it once those issues are solved. But at least we have them so we can add some features to it, such as OP shortcuts that are already available through commands. |
Well the reason is that having the close buttons there can very easy lead I'd be fine with a different solution than that, but there definitely is a On Sun, 6 Mar 2016, 07:31 Max-P, [email protected] wrote:
|
Fix github searching
erming/shout#613