updates to your_viewer #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
josephwkania
commented
May 14, 2021
josephwkania
commented
- removed variable from class
- image shows 4 stand devs instead of 5
- recycle median, stand dev instead of recalculating
- reformat some string lengths
…recalc, remove gs from object namespace, refromat some strings
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
=======================================
Coverage 73.36% 73.36%
=======================================
Files 16 16
Lines 2166 2166
=======================================
Hits 1589 1589
Misses 577 577 Continue to review full report at Codecov.
|
devanshkv
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.