Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed chisquare test from math.py/bandpass_fitter #80

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

josephwkania
Copy link
Member

Removed Chi Square test from bandpass_fitter logging, this would fail scipy's stricter test.
Linted smad_plotter

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2021

Codecov Report

Merging #80 (bd9b0c2) into master (1f4b393) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   73.35%   73.33%   -0.02%     
==========================================
  Files          16       16              
  Lines        2169     2168       -1     
==========================================
- Hits         1591     1590       -1     
  Misses        578      578              
Impacted Files Coverage Δ
your/utils/math.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f4b393...bd9b0c2. Read the comment docs.

@devanshkv devanshkv self-requested a review August 5, 2021 19:05
@devanshkv devanshkv self-assigned this Aug 5, 2021
@devanshkv devanshkv linked an issue Aug 5, 2021 that may be closed by this pull request
@devanshkv devanshkv merged commit 1514d4d into thepetabyteproject:master Aug 5, 2021
@devanshkv devanshkv mentioned this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests failing
3 participants