-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow use of sk_sg_filter by passing channel bandwidth and sampling interval #83
Conversation
@devanshkv sure, done |
@mef51 can you please modify the following test to include cases for your code: Lines 46 to 56 in 3d286d9
|
The test was failing because of the different signature. I moved the new kwargs to the end of the arg list to preserve the signature. Also added a test case for the new kwargs |
Awesome! Thank you so much! We are going to make a release soon and will make sure to detail your contributions and tag you. |
Thanks! Appreciate it. |
sk_sg_filter
only usesfoff
andtsamp
from theYour
class and I wanted to apply this on waterfalls without having to instantiate this class to use it. This change allows either use case: use withyour_object
or optionally passfoff
andtsamp
instead