Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AsyncAwsS3] adapt options for a temporary url same as in the AwsS3V3Adapter #1683

Merged

Conversation

smoench
Copy link
Contributor

@smoench smoench commented Jul 17, 2023

In this PR I added the possibility to provide additional options for the presign url. In our case we wanted to provide the ResponseContentDisposition but it wasn't possible.

I followed the same approach as in the AwsS3V3Adapter. With this change there is also no longer the requirement to use the SimpleS3Client to get a presigned url.

@smoench smoench changed the title [AsyncAwsS3] adapt GetResponse options same as in the AwsS3V3Adapter [AsyncAwsS3] adapt GetResponse options for a temporary url same as in the AwsS3V3Adapter Jul 17, 2023
@smoench smoench changed the title [AsyncAwsS3] adapt GetResponse options for a temporary url same as in the AwsS3V3Adapter [AsyncAwsS3] adapt options for a temporary url same as in the AwsS3V3Adapter Jul 18, 2023
@smoench
Copy link
Contributor Author

smoench commented Jul 27, 2023

Hey @frankdejonge,
sorry for pinging you here. I know you are busy right now but in case you find a free minute can you may have a look on this PR. Please let me know when there is something missing I can provide/fix :-)
Thanks in advance

@frankdejonge frankdejonge merged commit b11cba4 into thephpleague:3.x Jul 27, 2023
1 of 4 checks passed
@smoench smoench deleted the async-aws-adapter-presign-options branch July 28, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants