Resolve SettingsRepositoryInterface as late as possible #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives the opportunity to other extensions to change its implementation Also added the missing check for ForumSerializer so that the value only gets added to the forum payload and not every other serialized payload
|
@clarkwinkelmann thanks! I cannot test this right now or anytime soon because of several reasons but I will merge this pull request anyway because of your reputation with Flarum. |
|
I did test the PR locally before submitting it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives the opportunity to other extensions to change its implementation
Also added the missing check for ForumSerializer so that the value only gets added to the forum payload and not every other serialized payload
This change would allow extenders like the one I provide in https://github.com/clarkwinkelmann/flarum-local-extenders#override-settings to override the setting value.
Let me know if you would have preferred I keep the original file formatting. My PhpStorm automatically formatted the file according to PSR-2.
This second PR uses the solution @franzliedke recommended in #4