Fix unit tests

thomaschampagne · Apr 30, 2024 · bec8532 · bec8532
1 parent 5f1f29b
commit bec8532
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 39 deletions.
diff --git a/desktop/src/connectors/file/file.connector.spec.ts b/desktop/src/connectors/file/file.connector.spec.ts
@@ -124,8 +124,6 @@ describe("FileConnector", () => {
       return SportsLibProcessor.getEvent(activityFile.location.path);
     });
 
-    spyOn(fileConnector, "uploadToConnectorDebug").and.stub();
-
     // Same for activity computing: avoid worker use
     spyOn(fileConnector, "computeActivity").and.callFake(
       (
@@ -493,7 +491,9 @@ describe("FileConnector", () => {
 
       // Then
       syncEvent$.subscribe(
-        () => {},
+        () => {
+          // Nothing...
+        },
         error => {
           expect(error).toBeDefined();
           expect(syncEvents$NextSpy).toHaveBeenCalledWith(new StoppedSyncEvent(ConnectorType.FILE));

diff --git a/desktop/src/connectors/strava/strava.connector.spec.ts b/desktop/src/connectors/strava/strava.connector.spec.ts
@@ -127,8 +127,6 @@ describe("StravaConnector", () => {
     // Skip sleep to 0ms
     spyOn(stravaConnector.stravaApiClient, "sleep").and.returnValue(Promise.resolve());
 
-    spyOn(stravaConnector, "uploadStravaActivityInError").and.stub();
-
     // Avoid worker use for activity computing
     computeActivitySpy = spyOn(stravaConnector, "computeActivity").and.callFake(
       (
@@ -247,7 +245,9 @@ describe("StravaConnector", () => {
 
       // Then
       syncEvent$.pipe(filter(evt => evt.type !== SyncEventType.GENERIC)).subscribe(
-        () => {},
+        () => {
+          // Nothing...
+        },
         error => {
           expect(error).toBeDefined();
           expect(syncPagesSpy).toBeCalledTimes(expectedSyncPagesCalls);

diff --git a/desktop/src/connectors/strava/strava.connector.ts b/desktop/src/connectors/strava/strava.connector.ts
@@ -320,9 +320,6 @@ export class StravaConnector extends BaseConnector {
 
                       syncEvents$.next(errorSyncEvent); // Notify error
 
-                      // Upload activity for debug purpose
-                      this.uploadStravaActivityInError(stravaActivity, streams, error.message);
-
                       return Promise.resolve(); // Continue to next activity
                     });
                 },
@@ -672,31 +669,4 @@ export class StravaConnector extends BaseConnector {
       }
     });
   }
-
-  public uploadStravaActivityInError(stravaActivity: StravaActivity, streams: Streams, reason: string): void {
-    // Prepare source stravaActivity and streams
-    const payload = {
-      activity: stravaActivity,
-      streams: streams
-    };
-
-    const targetTmpPath = `${os.tmpdir()}/strava_activity_${stravaActivity.id}.json`;
-
-    fs.writeFile(targetTmpPath, JSON.stringify(payload), { flag: "w+" }, err => {
-      if (err) {
-        this.logger.error(`Unable to write strava debug file to ${targetTmpPath}. Error: ${err.message}`);
-      } else {
-        this.logger.info(`Saved strava debug data to ${targetTmpPath}`);
-        this.uploadActivityInError(
-          ConnectorType.STRAVA,
-          stravaActivity.type,
-          "json",
-          "elevate",
-          reason,
-          targetTmpPath,
-          stravaActivity.id
-        );
-      }
-    });
-  }
 }
diff --git a/desktop/src/specs/integration/file/file-activities.integration.spec.ts b/desktop/src/specs/integration/file/file-activities.integration.spec.ts
@@ -110,8 +110,6 @@ describe("File activities integration tests", () => {
       }
     );
 
-    spyOn(fileConnector, "uploadToConnectorDebug").and.stub();
-
     // Same for activity computing: avoid worker use
     spyOn(fileConnector, "computeActivity").and.callFake(
       (

diff --git a/desktop/src/specs/integration/strava/strava-activities.integration.spec.ts b/desktop/src/specs/integration/strava/strava-activities.integration.spec.ts
@@ -92,7 +92,6 @@ describe("Strava activities integration tests", () => {
 
     spyOn(stravaConnector.athleteSnapshotResolver, "resolve").and.returnValue(athleteSnapshotModel);
     spyOn(stravaConnector, "findLocalActivities").and.returnValue(Promise.resolve(null));
-    spyOn(stravaConnector, "uploadToConnectorDebug").and.stub();
 
     syncEventsSpy = spyOn(syncEvents$, "next").and.callThrough();