Fix webxrmanager #7

0b5vr · 2021-02-08T09:29:08Z

The primary motivation is to follow changes made in mrdoob/three.js#20754.

Update the type definition of WebXRManager.
Add a test about WebXR VR, webxr-vr-cube.ts.
Update the type definition of XRSession, since the test I mentioned above doesn't work without this change.

getReferenceSpace / getSession should be nullable

setSession should return Promise<void> instead of void since r125 See: mrdoob/three.js#20754

Trivial rename of arguments

webxr-vr-cube.ts, a simple example featuring WebXR VR

XRSession should extend EventTarget

Forgot to add `webxr-vr-cube.ts` to the tsconfig.json

joshuaellis

LGTM, thank you 👍🏼

FMS_Cat added 8 commits February 8, 2021 18:15

fix (three): update WebXRManager

0a47829

getReferenceSpace / getSession should be nullable

fix (three): Update WebXRManager

be7219f

setSession should return Promise<void> instead of void since r125 See: mrdoob/three.js#20754

fix (three): Update WebXRManager

4c98573

Trivial rename of arguments

test (three): add a test

5b72c0b

webxr-vr-cube.ts, a simple example featuring WebXR VR

fix (three): Update XRSession

6380a16

XRSession should extend EventTarget

chore (three): Modify tsconfig.json

a102226

Forgot to add `webxr-vr-cube.ts` to the tsconfig.json

docs: add FMS-Cat as a contributor

d079c34

refactor: ran prettier:write

de5182f

0b5vr mentioned this pull request Feb 8, 2021

[three] Fix type definition of WebXRManager DefinitelyTyped/DefinitelyTyped#51033

Closed

8 tasks

joshuaellis approved these changes Feb 8, 2021

View reviewed changes

joshuaellis merged commit f82d6ea into three-types:master Feb 8, 2021

0b5vr deleted the fix-webxrmanager branch February 8, 2021 10:10

Provide feedback