Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

Move elevation map loader #740

Merged
merged 17 commits into from
Dec 6, 2021
Merged

Conversation

taichiH
Copy link
Contributor

@taichiH taichiH commented Nov 26, 2021

Description

move elevation_map_loader from map_loader to create new elevation_map_loader as a member of perception module.

Review Procedure

This PR depend on these pull requests

please merge this pr with

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the guidelines.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@taichiH
Copy link
Contributor Author

taichiH commented Nov 30, 2021

merge after #745

@taichiH taichiH marked this pull request as ready for review November 30, 2021 07:00
@taichiH
Copy link
Contributor Author

taichiH commented Nov 30, 2021

build and test is failed because tier4/AutowareArchitectureProposal_api_msgs#1 hasn't been merged yet.

@kosuke55
Copy link
Contributor

kosuke55 commented Dec 1, 2021

Would you please add following params to elevation_map_parameters.yaml?

    height_type: 1
    height_thresh: 1.0

@kosuke55 kosuke55 self-requested a review December 1, 2021 11:47
@kosuke55 kosuke55 dismissed their stale review December 1, 2021 11:48

mistake review

@taichiH taichiH merged commit 3724917 into use-autoware-auto-msgs Dec 6, 2021
@taichiH taichiH deleted the move-elevation_map_loader branch December 6, 2021 07:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants