-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command palette #1160
Add command palette #1160
Conversation
won't be doing for wavetables because they don't have text and that would be impossible to search through with a keyboard
Is it still being worked on? |
Yes, but kinda slowly. I haven't had much time&motivation to work on this lately. |
Hello! I thought I had finished this around 2 months ago (hence me marking it as ready for review), but I realized I forgot to rename a few things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have accidentally changed the fmt submodule...
Please set it to the commit that upstream Furnace uses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work. Check out these two review comments.
Quick fix! Forgot that instrument numbers should be displayed as hexadecimal, so changed it in the code from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Will test later, but for now merging.
Attempt to add a command palette to furnace, to potentially facilitate finding specific actions and improve keyboard-only usage.
For more info, see this github discussion and this discord thread.
Right now this is quite an early version, though. Feel free to critique this as the design is still very fluid.
2023-06-15.01-38-46.mp4
Checklist