Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Japan support for Amazon Music #46

Closed
trustin opened this issue Mar 4, 2021 · 6 comments
Closed

Add Japan support for Amazon Music #46

trustin opened this issue Mar 4, 2021 · 6 comments
Assignees
@jiri-janousek
Labels
type: enhancement A new feature or an improvement of already present feature.

Comments

@trustin
Copy link

trustin commented Mar 4, 2021

Thank you for a great project. It'd be awesome if Japan is added to the country variant list. 🙇
@a-m-s
Copy link
Contributor

a-m-s commented Mar 4, 2021

What's the URL for that, please?

@trustin
Copy link
Author

trustin commented Mar 4, 2021

It's https://music.amazon.co.jp

a-m-s added a commit that referenced this issue Mar 4, 2021
@a-m-s
Add Japan
3a35663 
Issue #46
@a-m-s
Copy link
Contributor

a-m-s commented Mar 4, 2021

I've added an option to the preferences so you can set that as your "home" music site, but I can't check if the integration works because I don't speak Japanese and don't have an account at Amazon Japan.

This change will be included in the next Novula release (most likely). In the meantime, please use the "Load URL..." option from the Nuvola hamburger menu to navigate there yourself. It should already be accepted.

@a-m-s
Copy link
Contributor

a-m-s commented Mar 4, 2021

Please let me know if it works so I can close this issue.

@jiri-janousek
Copy link
Member

I'm going to publish fresh packages tomorrow.

@jiri-janousek jiri-janousek self-assigned this Mar 4, 2021
@jiri-janousek jiri-janousek added the type: enhancement A new feature or an improvement of already present feature. label Mar 4, 2021
@jiri-janousek
Copy link
Member

🍬 The feature was added to Amazon Cloud Player script version 1.5.2 (2-g3a35663). It's already available in 📦 the Nuvola Player flatpak repository (both stable and development branches). Thanks for reporting the issue 👍

@jiri-janousek jiri-janousek mentioned this issue Apr 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiri-janousek jiri-janousek

Labels
type: enhancement A new feature or an improvement of already present feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trustin @jiri-janousek @a-m-s