Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseTimeUsec crash #357

Closed
a-m-s opened this issue Jun 29, 2017 · 2 comments
Closed

parseTimeUsec crash #357

a-m-s opened this issue Jun 29, 2017 · 2 comments
Assignees
Labels
type: bug Something is not working as expected or the documentation is incorrect.
Milestone

Comments

@a-m-s
Copy link

a-m-s commented Jun 29, 2017

parseTimeUsec crashes when the hour component is present.

The problem looks like a simple typo: seconds -> tseconds

@jiri-janousek jiri-janousek self-assigned this Jul 11, 2017
@jiri-janousek jiri-janousek added the type: bug Something is not working as expected or the documentation is incorrect. label Jul 11, 2017
@jiri-janousek jiri-janousek added this to the July 2017 milestone Jul 11, 2017
@jiri-janousek
Copy link
Member

Thanks @a-m-s. Good catch.

jiri-janousek added a commit that referenced this issue Jul 19, 2017
Unit test included.

Issue: #357

Signed-off-by: Jiří Janoušek <[email protected]>
@jiri-janousek jiri-janousek modified the milestones: 4.6, July 2017 Jul 19, 2017
@jiri-janousek
Copy link
Member

Fixed + added test case.

jiri-janousek added a commit that referenced this issue Jul 29, 2017
-------------------------------

New Features:

  * Start-up system checks run in parallel to decrease start-up time.
    In case of any problem, only a single dialog is shown instead of
    multiple error dialogs or info bars.
  * WebKitGTK+ was upgraded to 2.16.6 fixing many security
    vulnerabilities and rendering issue.
  * Media Source Extension (MSE) is enabled in WebKitGTK as well as in
    Nuvola itself. This applies only to the genuine flatpak builds of
    Nuvola. MSE is required by some web apps for Flash-free audio/video
    playback.
  * New web app: BBC iPlayer by Andrew Stubbs. Note that this script
    requires MSE and may not work with third-party builds of Nuvola.
    Issue: #321

Bug fixes:

  * Graphics.dri2_get_driver_name() now throws error instead of an
    uncaught critical warning if it cannot connect to X Server.
    Issue: #359
  * Fixed typo in Nuvola.parseTimeUsec. Issue: #357
  * int64 is used for track position to avoid integer overflow.
    Issue: #358

News for Script Maintainers:

  * Developer sidebar can now change track rating.
  * Media player API documentation was updated with track rating.

Under the Hood:

  * New dependency:
    [unit.js](https://github.com/unitjs/unit.js/releases/tag/v2.0.0)
    2.0.0 (installed as /usr/share/javascript/unitjs/unit.js) is used
    for JavaScript unit tests (included in the test service
    - web_apps/test subdirectory).
  * Added support for org.gnome.SettingsDaemon.MediaKeys D-Bus name.
    [Upstream ticket](https://bugzilla.gnome.org/show_bug.cgi?id=781326).
  * The content of format support dialog was moved to Preferences
    dialog and various toggles were removed.
  * The content of bindings, models and interfaces directories was
    merged into components directory.

Signed-off-by: Jiří Janoušek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something is not working as expected or the documentation is incorrect.
Projects
None yet
Development

No branches or pull requests

2 participants