Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the device name/hostname to integrate.js #684

Closed
strugee opened this issue Dec 3, 2020 · 3 comments
Closed

Expose the device name/hostname to integrate.js #684

strugee opened this issue Dec 3, 2020 · 3 comments
Assignees
Labels
type: enhancement A new feature or an improvement of already present feature.

Comments

@strugee
Copy link
Contributor

strugee commented Dec 3, 2020

Is your feature request related to a problem? Please describe:

As I mentioned in #683, I need to register device information with the service I'm integrating into Nuvola. I'd like to get the device hostname to use as the "device name" in the service. Although a human-readable name (e.g. AJ's laptop vs ajs-laptop) would be better - I'm not sure if GNOME/other DEs distinguish between these?

Describe the solution you'd like:

The hostname or human-readable name (or both) should be exposed to integrate.js somewhere on the Nuvola object (or something like that).

Describe alternatives you've considered:

None, yet. The integration API for this service is kind of an all-or-nothing kind of deal, so I have to provide this information. I could hardcode it to something like "Linux device" or something like that but that seems... very unideal.

Additional context:

https://github.com/strugee/nuvola-app-jellyfin, https://jellyfin.org/

@jiri-janousek jiri-janousek added the type: enhancement A new feature or an improvement of already present feature. label Dec 5, 2020
@jiri-janousek jiri-janousek self-assigned this Dec 5, 2020
jiri-janousek added a commit to tiliado/diorite that referenced this issue Dec 5, 2020
jiri-janousek added a commit that referenced this issue Dec 5, 2020
@jiri-janousek
Copy link
Member

Hello @strugee, getting a hostname is easy but getting a pretty device name is tricky from the flatpak sandbox. I'll add only Nuvola.HOSTNAME for now.

@strugee
Copy link
Contributor Author

strugee commented Dec 5, 2020

Makes sense, thank you! Will this show up in ADK builds soon automatically or do I need to wait for you to cut a release?

@jiri-janousek
Copy link
Member

📌 The feature landed in the master branch of Nuvola Player and is already available in the master branch of 📦 Nuvola ADK flatpak package. flatpak run --command=nuvolaruntime eu.tiliado.NuvolaAdk//master -V should show Version 4.20.0-dev4 or later. It will be included in the next stable release Nuvola 4.20 scheduled for 🚀2020-12-27.

@jiri-janousek jiri-janousek mentioned this issue Dec 27, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A new feature or an improvement of already present feature.
Projects
None yet
Development

No branches or pull requests

2 participants